Review Request 111688: QVariantList-based ctor for KPluginInfo
Sebastian Kügler
sebas at kde.org
Mon Jul 29 00:25:55 UTC 2013
> On July 25, 2013, 4:32 p.m., David Faure wrote:
> > staging/kservice/src/services/kplugininfo.cpp, line 110
> > <http://git.reviewboard.kde.org/r/111688/diff/1/?file=173292#file173292line110>
> >
> > So "args" is a list of maps, any of which could contain a MetaData key? This seems strange. What's the intended behavior if we have two maps with a MetaData key?
Right, this feels a bit awkward, but this is what QPluginLoader::metaData() offers us, when we supply a simple json file.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111688/#review36498
-----------------------------------------------------------
On July 29, 2013, 12:25 a.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111688/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 12:25 a.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Description
> -------
>
> This patch allows KPluginInfo to be created from a QVariantList, as it is typically passed in from KPluginFactory (using the patch which changes the macro there).
>
>
> Diffs
> -----
>
> staging/kservice/src/services/kplugininfo.h c000008
> staging/kservice/src/services/kplugininfo.cpp bd1eaec
>
> Diff: http://git.reviewboard.kde.org/r/111688/diff/
>
>
> Testing
> -------
>
> Works with plugins built in the right way: A valid KPluginInfo is created from the plugin's metadata.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130729/5ffa9c59/attachment.html>
More information about the Kde-frameworks-devel
mailing list