Review Request 111688: QVariantList-based ctor for KPluginInfo

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111688/#review36498
-----------------------------------------------------------



staging/kservice/src/services/kplugininfo.h
<http://git.reviewboard.kde.org/r/111688/#comment26934>

    Missing "@deprecated since 5.0, use ... instead" in the documentation.



staging/kservice/src/services/kplugininfo.cpp
<http://git.reviewboard.kde.org/r/111688/#comment26937>

    So "args" is a list of maps, any of which could contain a MetaData key? This seems strange. What's the intended behavior if we have two maps with a MetaData key?



staging/kservice/src/services/kplugininfo.cpp
<http://git.reviewboard.kde.org/r/111688/#comment26935>

    Triple lookup in the map "m".
    Use value() (and storing that into a temp variable) to make a single lookup.



staging/kservice/src/services/kplugininfo.cpp
<http://git.reviewboard.kde.org/r/111688/#comment26936>

    Why "continue"? It's a no-op here. Did you mean "break"?


- David Faure


On July 25, 2013, 4:10 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111688/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> This patch allows KPluginInfo to be created from a QVariantList, as it is typically passed in from KPluginFactory (using the patch which changes the macro there).
> 
> 
> Diffs
> -----
> 
>   staging/kservice/src/services/kplugininfo.h c000008 
>   staging/kservice/src/services/kplugininfo.cpp bd1eaec 
> 
> Diff: http://git.reviewboard.kde.org/r/111688/diff/
> 
> 
> Testing
> -------
> 
> Works with plugins built in the right way: A valid KPluginInfo is created from the plugin's metadata.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130725/6481be74/attachment.html>