Review Request 111702: Move K4AboutData and KComponentData to kde4support

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111702/#review36604
-----------------------------------------------------------


If kdelibs and plasma-framework compile (preferrably after removing the install dir), then yes it's enough :)

This task only became possible after the port from KCmdLineArgs to QCommandLineParser, because KCmdLineArgs is heavily based on K4AboutData. This is why we couldn't do it before.

Thanks!


kdecore/kernel/kcomponentdata.cpp
<http://git.reviewboard.kde.org/r/111702/#comment27011>

    This change is wrong. This is about finding the symbol kde_kiosk_exception exported by kconfigcore, so KCONFIGCORE_EXPORT was correct.


- David Faure


On July 27, 2013, 12:42 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111702/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 12:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Is this enough?
> 
> 
> Diffs
> -----
> 
>   kdecore/CMakeLists.txt e0926ba 
>   kdecore/kernel/k4aboutdata.h f50e750 
>   kdecore/kernel/k4aboutdata.cpp 76b274d 
>   kdecore/kernel/kcomponentdata.h c699870 
>   kdecore/kernel/kcomponentdata.cpp 9bc246f 
>   kdecore/kernel/kcomponentdata_p.h  
>   staging/kde4support/src/CMakeLists.txt 24bcff3 
> 
> Diff: http://git.reviewboard.kde.org/r/111702/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130727/51489b12/attachment.html>