<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111702/">http://git.reviewboard.kde.org/r/111702/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If kdelibs and plasma-framework compile (preferrably after removing the install dir), then yes it's enough :)
This task only became possible after the port from KCmdLineArgs to QCommandLineParser, because KCmdLineArgs is heavily based on K4AboutData. This is why we couldn't do it before.
Thanks!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111702/diff/3/?file=173930#file173930line202" style="color: black; font-weight: bold; text-decoration: underline;">staging/kde4support/src/kdecore/kcomponentdata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KComponentDataPrivate::lazyInit()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">202</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">extern</span> <span class="n">K<span class="hl">CONFIGCORE</span>_EXPORT</span> <span class="kt">bool</span> <span class="n">kde_kiosk_exception</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">202</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">extern</span> <span class="n">K<span class="hl">DE4SUPPORT</span>_EXPORT</span> <span class="kt">bool</span> <span class="n">kde_kiosk_exception</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change is wrong. This is about finding the symbol kde_kiosk_exception exported by kconfigcore, so KCONFIGCORE_EXPORT was correct.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On July 27th, 2013, 12:42 p.m. UTC, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated July 27, 2013, 12:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this enough?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/CMakeLists.txt <span style="color: grey">(e0926ba)</span></li>
<li>kdecore/kernel/k4aboutdata.h <span style="color: grey">(f50e750)</span></li>
<li>kdecore/kernel/k4aboutdata.cpp <span style="color: grey">(76b274d)</span></li>
<li>kdecore/kernel/kcomponentdata.h <span style="color: grey">(c699870)</span></li>
<li>kdecore/kernel/kcomponentdata.cpp <span style="color: grey">(9bc246f)</span></li>
<li>kdecore/kernel/kcomponentdata_p.h <span style="color: grey">()</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(24bcff3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111702/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>