Review Request 111584: Use correct path for including export headers

[Alexander Richardson]

> On July 23, 2013, 11:35 a.m., Kevin Ottens wrote:
> > tier1/sonnet/src/ui/configdialog.h, line 25
> > <http://git.reviewboard.kde.org/r/111584/diff/1/?file=172213#file172213line25>
> >
> >     Are you sure about this one and the followings? It's odd if you need them as it just change the priority order to look for said header (first in the cwd then in the include path).

This is what all the other headers do with "sonnetcore_export.h", so I did the same here.

The problem is that include/sonnet is not part of the include paths when using sonnet.

Alternatively I could change it to <sonnet/sonnetui_export.h> and do the same with all the "sonnetcore_export.h" includes


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111584/#review36347
-----------------------------------------------------------


On July 19, 2013, 12:29 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111584/
> -----------------------------------------------------------
> 
> (Updated July 19, 2013, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Use correct path for including export headers
> 
> 
> Diffs
> -----
> 
>   kio/bookmarks/kbookmark.h dbcb8b0c5ff1e6205887b030d9bcd200b19f4180 
>   kio/kio/kfileitemdelegate.h 0943f0c3090d378a2db092a879bab81d1882deb5 
>   staging/ktextwidgets/src/widgets/ktextedit.h 04bf8d59d2b6aafa57049f6bf5ad4bdda4523166 
>   tier1/sonnet/src/ui/configdialog.h 93dcbcac6684a8a8df80697ab2f7a8113abe1897 
>   tier1/sonnet/src/ui/configwidget.h 8f23184888078968d406275f140b60332997f0aa 
>   tier1/sonnet/src/ui/dialog.h 84947be62e121a011c3440aa91346057abe1988c 
>   tier1/sonnet/src/ui/highlighter.h e275aec84eb729bbff2a7f75c8468cc65cb93d8c 
> 
> Diff: http://git.reviewboard.kde.org/r/111584/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> Also my test project using KF5 now works without having to manually add more include paths
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130723/5e21548a/attachment.html>