Review Request 111584: Use correct path for including export headers

Kevin Ottens ervin at kde.org
Tue Jul 23 09:35:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111584/#review36347
-----------------------------------------------------------



tier1/sonnet/src/ui/configdialog.h
<http://git.reviewboard.kde.org/r/111584/#comment26841>

    Are you sure about this one and the followings? It's odd if you need them as it just change the priority order to look for said header (first in the cwd then in the include path).


- Kevin Ottens


On July 18, 2013, 10:29 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111584/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 10:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Use correct path for including export headers
> 
> 
> Diffs
> -----
> 
>   kio/bookmarks/kbookmark.h dbcb8b0c5ff1e6205887b030d9bcd200b19f4180 
>   kio/kio/kfileitemdelegate.h 0943f0c3090d378a2db092a879bab81d1882deb5 
>   staging/ktextwidgets/src/widgets/ktextedit.h 04bf8d59d2b6aafa57049f6bf5ad4bdda4523166 
>   tier1/sonnet/src/ui/configdialog.h 93dcbcac6684a8a8df80697ab2f7a8113abe1897 
>   tier1/sonnet/src/ui/configwidget.h 8f23184888078968d406275f140b60332997f0aa 
>   tier1/sonnet/src/ui/dialog.h 84947be62e121a011c3440aa91346057abe1988c 
>   tier1/sonnet/src/ui/highlighter.h e275aec84eb729bbff2a7f75c8468cc65cb93d8c 
> 
> Diff: http://git.reviewboard.kde.org/r/111584/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> Also my test project using KF5 now works without having to manually add more include paths
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130723/8718b1e8/attachment.html>


More information about the Kde-frameworks-devel mailing list