Review Request 111492: rename kservice framework lib to KService

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111492/#review35903
-----------------------------------------------------------


Looks ok.
You are creating a separate Targets.cmake file now. Does that already work, i.e. kservice does not link against any kdelibs (except tier1/ and tier2/) libraries anymore ?

And as for kde4support, while you're at it and touching all the places where this is used, I'd suggest to change the places where it is used to use ${KService_LIBRARIES}, and set this variable in the toplevel CMakeLists.txt to KService.

One more thing which needs to be done (but unrelated to this change here) is that kservice shouldn't use the target names like KCoreAddons directly. When it will be built separately, the name will be KF5::KCoreAddons. By using ${KCoreAddons_LIBRARIES} already now KService can be built both as part of kdelibs as well as separately, without the need for a switch day.

Thanks

- Alexander Neundorf


On July 12, 2013, 1:04 p.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111492/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 1:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> In order to have all frameworks using the same name policy (i.e. use CamelCase for libraries names) rename kservice framework lib to KService
> 
> 
> Diffs
> -----
> 
>   kdecore/CMakeLists.txt 96601f6 
>   staging/kemoticons/src/core/CMakeLists.txt 1e375a7 
>   staging/kio/src/core/CMakeLists.txt 1d6938f 
>   staging/kservice/CMakeLists.txt 1f95c64 
>   staging/kservice/KServiceConfig.cmake.in PRE-CREATION 
>   staging/kservice/autotests/CMakeLists.txt 93c5f16 
>   staging/kservice/kserviceConfig.cmake.in a9df049 
>   staging/kservice/src/CMakeLists.txt ff61349 
>   staging/ktextwidgets/src/CMakeLists.txt 6b3c09f 
>   staging/kwidgets/src/CMakeLists.txt 9ae3c2e 
> 
> Diff: http://git.reviewboard.kde.org/r/111492/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Port
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130712/c9c621e8/attachment.html>