<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111492/">http://git.reviewboard.kde.org/r/111492/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks ok.
You are creating a separate Targets.cmake file now. Does that already work, i.e. kservice does not link against any kdelibs (except tier1/ and tier2/) libraries anymore ?
And as for kde4support, while you're at it and touching all the places where this is used, I'd suggest to change the places where it is used to use ${KService_LIBRARIES}, and set this variable in the toplevel CMakeLists.txt to KService.
One more thing which needs to be done (but unrelated to this change here) is that kservice shouldn't use the target names like KCoreAddons directly. When it will be built separately, the name will be KF5::KCoreAddons. By using ${KCoreAddons_LIBRARIES} already now KService can be built both as part of kdelibs as well as separately, without the need for a switch day.
Thanks</pre>
<br />
<p>- Alexander</p>
<br />
<p>On July 12th, 2013, 1:04 p.m. UTC, Benjamin Port wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Benjamin Port.</div>
<p style="color: grey;"><i>Updated July 12, 2013, 1:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In order to have all frameworks using the same name policy (i.e. use CamelCase for libraries names) rename kservice framework lib to KService</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/CMakeLists.txt <span style="color: grey">(96601f6)</span></li>
<li>staging/kemoticons/src/core/CMakeLists.txt <span style="color: grey">(1e375a7)</span></li>
<li>staging/kio/src/core/CMakeLists.txt <span style="color: grey">(1d6938f)</span></li>
<li>staging/kservice/CMakeLists.txt <span style="color: grey">(1f95c64)</span></li>
<li>staging/kservice/KServiceConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/autotests/CMakeLists.txt <span style="color: grey">(93c5f16)</span></li>
<li>staging/kservice/kserviceConfig.cmake.in <span style="color: grey">(a9df049)</span></li>
<li>staging/kservice/src/CMakeLists.txt <span style="color: grey">(ff61349)</span></li>
<li>staging/ktextwidgets/src/CMakeLists.txt <span style="color: grey">(6b3c09f)</span></li>
<li>staging/kwidgets/src/CMakeLists.txt <span style="color: grey">(9ae3c2e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111492/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>