Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

[Thomas Lübking]

> On June 3, 2013, 9:59 a.m., David Faure wrote:
> > For the record, this is waiting for an updated version of https://codereview.qt-project.org/#change,51166
> 
> Kevin Ottens wrote:
>     Which is still not seeing any activity... Alex do you need help there?

That patch really needs to send the widget to the stylehint query (animating some inheriting 3rd party widget might be broken or dog slow and then you end up with either no animations at all or for that application or crashing it) and it actually could make use of the QStyleHintReturn to determine animation duration (to be controlled by styles or a kde global setting etc.)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109527/#review33625
-----------------------------------------------------------


On March 16, 2013, 7:16 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109527/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port to the incoming (hopefully) styleHint SH_Widget_Animate
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/klineedit.cpp d29296c 
>   kdeui/widgets/klineedit_p.h 7c58f2d 
>   kdeui/widgets/kmainwindow.cpp e629454 
>   kdeui/widgets/kmessagewidget.cpp ce0852f 
>   kio/kfile/kimagefilepreview.cpp cbd3c43 
>   kio/kio/kfileitemdelegate.cpp c11d6b6 
>   staging/kde4support/src/kdeui/kfadewidgeteffect.cpp e182a1b 
> 
> Diff: http://git.reviewboard.kde.org/r/109527/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130710/201977a9/attachment.html>