Review Request 111422: Add addActions(QList<QAction *>) to KActionCollection
Kevin Ottens
ervin at kde.org
Mon Jul 8 11:20:57 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111422/#review35730
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On July 6, 2013, 6:12 p.m., Andrea Scarpino wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111422/
> -----------------------------------------------------------
>
> (Updated July 6, 2013, 6:12 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Description
> -------
>
> In review https://git.reviewboard.kde.org/r/111424/ KRichTextWidget::createActions(KActionCollection *actionCollection) has been changed to QList<QAction *> KRichTextWidget::createActions() to remove the dependency on KActionCollection.
>
> Effect of this change is that people have to add each action to the collection now. This method simplify things by allowing to add them all with a single call.
>
>
> Diffs
> -----
>
> kdeui/actions/kactioncollection.h 8ca6845
> kdeui/actions/kactioncollection.cpp 7dc2987
>
> Diff: http://git.reviewboard.kde.org/r/111422/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrea Scarpino
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130708/98367e0f/attachment.html>
More information about the Kde-frameworks-devel
mailing list