Review Request 111422: Add addActions(QList<QAction *>) to KActionCollection

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111422/#review35675
-----------------------------------------------------------

Ship it!



kdeui/actions/kactioncollection.h
<http://git.reviewboard.kde.org/r/111422/#comment26163>

    I'm surprised by the & and * syntax here, seems weird.
    
    How about addAction(), or addAction(QString, QAction*)?


- David Faure


On July 6, 2013, 6:12 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111422/
> -----------------------------------------------------------
> 
> (Updated July 6, 2013, 6:12 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> In review https://git.reviewboard.kde.org/r/111424/ KRichTextWidget::createActions(KActionCollection *actionCollection) has been changed to QList<QAction *> KRichTextWidget::createActions() to remove the dependency on KActionCollection.
> 
> Effect of this change is that people have to add each action to the collection now. This method simplify things by allowing to add them all with a single call.
> 
> 
> Diffs
> -----
> 
>   kdeui/actions/kactioncollection.h 8ca6845 
>   kdeui/actions/kactioncollection.cpp 7dc2987 
> 
> Diff: http://git.reviewboard.kde.org/r/111422/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130707/5762365e/attachment.html>