Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111405/#review35638
-----------------------------------------------------------


This review has been submitted with commit 2bc7b4accfc6daf9ac8524729393da002bbd77cf by Aleix Pol to branch frameworks.

- Commit Hook


On July 5, 2013, 2:25 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111405/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> We want to deprecate KGlobalSettings, but we need to keep the createApplicationPalette functionality.
> 
> I decided to move it to KColorScheme. We have 2 kind of users for this method:
> - applications that want to do fancy stuff with KDE and integrate better which will have to depend on KWidgets
> - and the rest, who will be able to rely on a properly set QPalette (by whichever QPlatformTheme we're using on).
> 
> Having moved the method to KColorScheme, seems to me we can use it from our Platform Theme, because it was doing mostly the same.
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kstyle.cpp 9cb0fd2 
>   kdeui/util/kglobalsettings.h 4b77ed5 
>   kdeui/util/kglobalsettings.cpp 3e60632 
>   staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 7b660f0 
>   staging/kwidgets/src/utils/kcolorscheme.h 3ee47be 
>   staging/kwidgets/src/utils/kcolorscheme.cpp a270878 
> 
> Diff: http://git.reviewboard.kde.org/r/111405/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130705/cd696854/attachment.html>