<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111405/">http://git.reviewboard.kde.org/r/111405/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 2bc7b4accfc6daf9ac8524729393da002bbd77cf by Aleix Pol to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 5th, 2013, 2:25 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated July 5, 2013, 2:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We want to deprecate KGlobalSettings, but we need to keep the createApplicationPalette functionality.
I decided to move it to KColorScheme. We have 2 kind of users for this method:
- applications that want to do fancy stuff with KDE and integrate better which will have to depend on KWidgets
- and the rest, who will be able to rely on a properly set QPalette (by whichever QPlatformTheme we're using on).
Having moved the method to KColorScheme, seems to me we can use it from our Platform Theme, because it was doing mostly the same.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kernel/kstyle.cpp <span style="color: grey">(9cb0fd2)</span></li>
<li>kdeui/util/kglobalsettings.h <span style="color: grey">(4b77ed5)</span></li>
<li>kdeui/util/kglobalsettings.cpp <span style="color: grey">(3e60632)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp <span style="color: grey">(7b660f0)</span></li>
<li>staging/kwidgets/src/utils/kcolorscheme.h <span style="color: grey">(3ee47be)</span></li>
<li>staging/kwidgets/src/utils/kcolorscheme.cpp <span style="color: grey">(a270878)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111405/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>