Review Request 111319: Move kmessagewidget to kwidgetsaddons
Kevin Ottens
ervin at kde.org
Tue Jul 2 08:14:51 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111319/#review35419
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On July 1, 2013, 4:16 p.m., Romário Rios wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111319/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 4:16 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Moves kmessagewidget to kwidgetsaddons framework and removes all KDE dependencies from it. I don't know how to get the Close button shortcuts the same way it was gotten in kglobalactions, but I don't know if it's necessary in the case of this widget specifically.
>
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt ab43f17
> kdeui/tests/CMakeLists.txt f489b6b
> kdeui/tests/kmessagewidgettest.cpp eb151b9
> kdeui/widgets/kmessagewidget.h 9fbb176
> kdeui/widgets/kmessagewidget.cpp 7fb91e8
> tier1/kwidgetsaddons/src/CMakeLists.txt 5a37efa
> tier1/kwidgetsaddons/tests/CMakeLists.txt 9738c6c
>
> Diff: http://git.reviewboard.kde.org/r/111319/diff/
>
>
> Testing
> -------
>
> Compiles, test runs fine.
>
>
> Thanks,
>
> Romário Rios
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/fa220ce4/attachment.html>
More information about the Kde-frameworks-devel
mailing list