Review Request 111319: Move kmessagewidget to kwidgetsaddons

Romário Rios luizromario at gmail.com
Mon Jul 1 16:16:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111319/
-----------------------------------------------------------

(Updated July 1, 2013, 4:16 p.m.)


Review request for KDE Frameworks.


Changes
-------

Changes proposed by ervin.


Description
-------

Moves kmessagewidget to kwidgetsaddons framework and removes all KDE dependencies from it. I don't know how to get the Close button shortcuts the same way it was gotten in kglobalactions, but I don't know if it's necessary in the case of this widget specifically.


Diffs (updated)
-----

  kdeui/CMakeLists.txt ab43f17 
  kdeui/tests/CMakeLists.txt f489b6b 
  kdeui/tests/kmessagewidgettest.cpp eb151b9 
  kdeui/widgets/kmessagewidget.h 9fbb176 
  kdeui/widgets/kmessagewidget.cpp 7fb91e8 
  tier1/kwidgetsaddons/src/CMakeLists.txt 5a37efa 
  tier1/kwidgetsaddons/tests/CMakeLists.txt 9738c6c 

Diff: http://git.reviewboard.kde.org/r/111319/diff/


Testing
-------

Compiles, test runs fine.


Thanks,

Romário Rios

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130701/047c3b66/attachment.html>


More information about the Kde-frameworks-devel mailing list