Review Request 111348: Don't require KApplication for using KGlobalSettings

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111348/#review35380
-----------------------------------------------------------


Veto. This ignores the history behind activate().

Commit log has the reason:
"    - Don't let kde plugins change the font of a non-kde application "

If a Qt-designer plugin links to the lib that contains this code, it will suddenly apply the kglobalsettings to the whole process, which is exactly why we introduced activate() : so that it's only applied explicitely in *apps* that want it.

IMHO KGlobalSettings should end up in kde4support with KApplication, so either apps use both or none, so the activate() in kapp does the job like in kde4.


- David Faure


On July 1, 2013, 5:18 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111348/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 5:18 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Initialize it when QCoreApplication is initialized, no matter what.
> 
> KApplication keeps the call to KGlobalSettings::activate(), it just won't do anything the second time that it's called. Behavior shouldn't change, if AFAIK.
> 
> Now KGlobalSettings will be initialized automatically, as long as the application links against kde4support
> 
> 
> Diffs
> -----
> 
>   kdeui/util/kglobalsettings.cpp 3e60632 
> 
> Diff: http://git.reviewboard.kde.org/r/111348/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130701/26bc1ef2/attachment.html>