<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111348/">http://git.reviewboard.kde.org/r/111348/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Veto. This ignores the history behind activate().
Commit log has the reason:
" - Don't let kde plugins change the font of a non-kde application "
If a Qt-designer plugin links to the lib that contains this code, it will suddenly apply the kglobalsettings to the whole process, which is exactly why we introduced activate() : so that it's only applied explicitely in *apps* that want it.
IMHO KGlobalSettings should end up in kde4support with KApplication, so either apps use both or none, so the activate() in kapp does the job like in kde4.
</pre>
<br />
<p>- David</p>
<br />
<p>On July 1st, 2013, 5:18 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated July 1, 2013, 5:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initialize it when QCoreApplication is initialized, no matter what.
KApplication keeps the call to KGlobalSettings::activate(), it just won't do anything the second time that it's called. Behavior shouldn't change, if AFAIK.
Now KGlobalSettings will be initialized automatically, as long as the application links against kde4support</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/util/kglobalsettings.cpp <span style="color: grey">(3e60632)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111348/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>