Review Request 108449: Adjust to Julian Day computation in Qt5's QDate
Kevin Ottens
ervin at kde.org
Thu Jan 17 16:27:38 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108449/
-----------------------------------------------------------
Review request for KDE Frameworks, David Faure, John Layt, and Jon Severinsson.
Description
-------
Adjust to Julian Day computation in Qt5's QDate
Qt5 uses a new algorithm for deal with julian days so adjust
KCalendarSystem to it. Because of that change, January 1st -4712 is not
a wednesday anymore but a saturday, so one of the cases for ISO Week
date is not testable anymore (hence adjustment in tests).
It finally makes kcalendartest pass.
Diffs
-----
kdecore/date/kcalendarsystemqdate.cpp f07e93b1ac87b1081cffe0702370cfe0048837c2
kdecore/tests/kcalendartest.cpp c6077206ac7772f8356f93f680c203fa58ba06fa
Diff: http://git.reviewboard.kde.org/r/108449/diff/
Testing
-------
All kdelibs/frameworks unit tests pass when built against Qt5 dev.
Thanks,
Kevin Ottens
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130117/ca5d5cc9/attachment.html>
More information about the Kde-frameworks-devel
mailing list