Review Request 107690: [PATCH 3/4] kcalendarsystem: Simplify week() and weeksInYear() implementations

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107690/#review25349
-----------------------------------------------------------

Ship it!


Looks OK to me.

- David Faure


On Jan. 8, 2013, 3:40 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107690/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 3:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> These only depend on the week system (i.e. KLocale::WeekNumberSystem) used, not the calendar used, and thus need not be (d-pointer) virtual.
> 
> 
> Diffs
> -----
> 
>   kdecore/date/kcalendarsystem.h efddd08 
>   kdecore/date/kcalendarsystem.cpp 198a863 
>   kdecore/date/kcalendarsystemprivate_p.h d935ead 
> 
> Diff: http://git.reviewboard.kde.org/r/107690/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130113/63ee706d/attachment.html>