Review Request: [PATCH 3/4] kcalendarsystem: Simplify week() and weeksInYear() implementations

Jon Severinsson jon at severinsson.net
Tue Jan 8 15:40:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107690/
-----------------------------------------------------------

(Updated Jan. 8, 2013, 3:40 p.m.)


Review request for KDE Frameworks.


Changes
-------

Rebased the series on top of review #108263


Description
-------

These only depend on the week system (i.e. KLocale::WeekNumberSystem) used, not the calendar used, and thus need not be (d-pointer) virtual.


Diffs (updated)
-----

  kdecore/date/kcalendarsystem.h efddd08 
  kdecore/date/kcalendarsystem.cpp 198a863 
  kdecore/date/kcalendarsystemprivate_p.h d935ead 

Diff: http://git.reviewboard.kde.org/r/107690/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130108/8dc8dddb/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list