Review Request 107687: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107687/#review25347
-----------------------------------------------------------

Ship it!


Seems fine, please commit.

As you write in a comment, we can always make the method virtual again in the future, given that it's in a Private class.

- David Faure


On Jan. 8, 2013, 3:40 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107687/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 3:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> All calendar systems supported by KCalendarSystem have 7 days per week,
> so simplify some code by centralizing that figure.
> 
> 
> Diffs
> -----
> 
>   kdecore/date/kcalendarsystem.h efddd08 
>   kdecore/date/kcalendarsystem.cpp 198a863 
>   kdecore/date/kcalendarsystemcoptic.cpp 43d2611 
>   kdecore/date/kcalendarsystemcopticprivate_p.h 35907ff 
>   kdecore/date/kcalendarsystemgregorian.cpp 663cd1b 
>   kdecore/date/kcalendarsystemgregorianprivate_p.h fb7a0dd 
>   kdecore/date/kcalendarsystemhebrew.cpp fd66fa2 
>   kdecore/date/kcalendarsystemindiannational.cpp 2cbfe23 
>   kdecore/date/kcalendarsystemislamiccivil.cpp 774e081 
>   kdecore/date/kcalendarsystemjalali.cpp 486ef16 
>   kdecore/date/kcalendarsystemjulian.cpp 23988e8 
>   kdecore/date/kcalendarsystemprivate_p.h d935ead 
>   kdecore/date/kdatetimeparser.cpp a416808 
> 
> Diff: http://git.reviewboard.kde.org/r/107687/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130113/36914531/attachment.html>