<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107687/">http://git.reviewboard.kde.org/r/107687/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems fine, please commit.
As you write in a comment, we can always make the method virtual again in the future, given that it's in a Private class.</pre>
<br />
<p>- David</p>
<br />
<p>On January 8th, 2013, 3:40 p.m. UTC, Jon Severinsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2013, 3:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All calendar systems supported by KCalendarSystem have 7 days per week,
so simplify some code by centralizing that figure.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/date/kcalendarsystem.h <span style="color: grey">(efddd08)</span></li>
<li>kdecore/date/kcalendarsystem.cpp <span style="color: grey">(198a863)</span></li>
<li>kdecore/date/kcalendarsystemcoptic.cpp <span style="color: grey">(43d2611)</span></li>
<li>kdecore/date/kcalendarsystemcopticprivate_p.h <span style="color: grey">(35907ff)</span></li>
<li>kdecore/date/kcalendarsystemgregorian.cpp <span style="color: grey">(663cd1b)</span></li>
<li>kdecore/date/kcalendarsystemgregorianprivate_p.h <span style="color: grey">(fb7a0dd)</span></li>
<li>kdecore/date/kcalendarsystemhebrew.cpp <span style="color: grey">(fd66fa2)</span></li>
<li>kdecore/date/kcalendarsystemindiannational.cpp <span style="color: grey">(2cbfe23)</span></li>
<li>kdecore/date/kcalendarsystemislamiccivil.cpp <span style="color: grey">(774e081)</span></li>
<li>kdecore/date/kcalendarsystemjalali.cpp <span style="color: grey">(486ef16)</span></li>
<li>kdecore/date/kcalendarsystemjulian.cpp <span style="color: grey">(23988e8)</span></li>
<li>kdecore/date/kcalendarsystemprivate_p.h <span style="color: grey">(d935ead)</span></li>
<li>kdecore/date/kdatetimeparser.cpp <span style="color: grey">(a416808)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107687/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>