Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap
Valentin Rusu
kde at rusu.info
Fri Jan 4 21:18:08 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107973/
-----------------------------------------------------------
(Updated Jan. 4, 2013, 9:18 p.m.)
Review request for KDE Frameworks and Kevin Ottens.
Changes
-------
Ok Kevin, that was quite a ride :)
Here is the updated patch.
Description
-------
This changeset removes all gesture facilities from KAction and define them in KGestureMap. Thanks for the feedback.
Diffs (updated)
-----
KDE5PORTING.html 86dfc1a
kdeui/actions/kaction.h f45c94d
kdeui/actions/kaction.cpp b78d1d6
kdeui/actions/kaction_p.h f87272c
kdeui/dialogs/kshortcutseditor.cpp 5653984
kdeui/dialogs/kshortcutseditoritem.cpp e85a203
kdeui/shortcuts/kgesturemap.h 56b42b6
kdeui/shortcuts/kgesturemap.cpp 1350dbe
Diff: http://git.reviewboard.kde.org/r/107973/diff/
Testing
-------
Code builds OK. KGestureMap is not actually used, though, as KGestureMap::eventFilter method return false right away.
Thanks,
Valentin Rusu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130104/ef86a903/attachment.html>
More information about the Kde-frameworks-devel
mailing list