khtml uses qx11info_x11 without checking for qtx11support

Alexander Neundorf neundorf at kde.org
Sun Feb 10 18:27:59 UTC 2013


On Sunday 10 February 2013, Stephen Kelly wrote:
> Treeve Jelbert wrote:
> > /var/git/kf5/khtml/khtmlview.cpp:36:26: fatal error: qx11info_x11.h: No
> > such file or directory
> > compilation terminated.
> > 
> > Also qtx11support is broken, still uses obsolete QT_{BEGIN,END}_HEADER
> 
> Please make sure you are using codereview.qt-project.org:qt/qtx11extras.

can we please document that process somewhere ?

Yesterday evening I wanted to push some small change, but couldn't do that 
because I was suddenly required to update Qt.

What is the recommended way to do that ?

I spent quite some time today to get qtx11extras, without help from #qt-labs 
on IRC I wouldn't have managed it. Thanks Thiago :-)

I did some combination of "git pull", "git submodule update", "git submodule 
foreach 'git pull || true'" and "git submodule init" and repeated some of 
them. At some point I got an empty qtx11extras file, and finally it was filled 
with content.

Can the process of updating qt please be documented here ?
http://community.kde.org/Frameworks/Building

Thanks
Alex


More information about the Kde-frameworks-devel mailing list