Review Request 114727: Unconditionally skip ICU-dependent encoding tests in kcharsettest

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114727/#review46446
-----------------------------------------------------------


The commit message is a bit misleading btw: these codecs are not missing if Qt was compiled without ICU support, but if it was compiled *with* ICU support.
Bug in ICU, it seems, at least for iso-8859-16.

This prompted me to email Lars about the missing ISO-8859-16 support in the ICU codec. Meanwhile we can postpone this by one more release. Let's increase to 5.4, otherwise we'll forget forever. I'll commit that.

- David Faure


On Dec. 29, 2013, 6:04 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114727/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2013, 6:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcodecs
> 
> 
> Description
> -------
> 
> Unconditionally skip ICU-dependent encoding tests
>     
> Qt 5.2 and the current 5.3 dev branch have still not resolved the issue
> of certain encodings only being available if Qt was compiled with ICU
> support.  Since we do not know when it will be fixed, always skip this
> part of the test regardless of the Qt version.  This can be resolved as
> and when the issue is fixed in Qt.
> 
> 
> NB: I am away until 2nd Jan, so if it gets a "ship it", feel free to commit it in my absence in order to get Jenkins green again.
> 
> 
> Diffs
> -----
> 
>   autotests/kcharsetstest.cpp 98039249d4e44e43b6cada614a4352367ea57c05 
> 
> Diff: https://git.reviewboard.kde.org/r/114727/diff/
> 
> 
> Testing
> -------
> 
> Still compiles, kcharsettest still runs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131230/45fc7fd7/attachment-0001.html>