<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114727/">https://git.reviewboard.kde.org/r/114727/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The commit message is a bit misleading btw: these codecs are not missing if Qt was compiled without ICU support, but if it was compiled *with* ICU support.
Bug in ICU, it seems, at least for iso-8859-16.
This prompted me to email Lars about the missing ISO-8859-16 support in the ICU codec. Meanwhile we can postpone this by one more release. Let's increase to 5.4, otherwise we'll forget forever. I'll commit that.</pre>
<br />
<p>- David Faure</p>
<br />
<p>On December 29th, 2013, 6:04 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2013, 6:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcodecs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unconditionally skip ICU-dependent encoding tests
Qt 5.2 and the current 5.3 dev branch have still not resolved the issue
of certain encodings only being available if Qt was compiled with ICU
support. Since we do not know when it will be fixed, always skip this
part of the test regardless of the Qt version. This can be resolved as
and when the issue is fixed in Qt.
NB: I am away until 2nd Jan, so if it gets a "ship it", feel free to commit it in my absence in order to get Jenkins green again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still compiles, kcharsettest still runs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kcharsetstest.cpp <span style="color: grey">(98039249d4e44e43b6cada614a4352367ea57c05)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114727/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>