Review Request 114705: Remove classpreviews.{cpp, h} from kdesignerplugin

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114705/#review46357
-----------------------------------------------------------

Ship it!


Hehe, this is from 2001, back when designer was generating the whole dialog, not just its child widgets.

Commit log:
    
    - You can now implement preview classes that cannot be directly added to
      designer (in classpreviews.*), e.g. call reparent() for dialogs or insert
      example values.
    
      => You can now create a KDialog
    
-> Doesn't apply at all anymore.

- David Faure


On Dec. 28, 2013, 3:07 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114705/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 3:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> -------
> 
> Remove classpreviews.{cpp,h}
> 
> It only contains a single class - KDialogPreview - which is unused
> anywhere.
> 
> 
> NB: this doesn't need to go into TP1, but if I don't post these patches, I'll forget I have them.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 3e51888614358e71756774f6bbfd5d3c14921947 
>   src/classpreviews.h ec5545be046022917e9c6a6df6610f32965cccf9 
>   src/classpreviews.cpp 1ae771162a844dd8efae3a110a1e056513ea01fe 
>   src/kde.widgets 65f38391fe0cbffd1e8e000d1ce29dd483bc72fc 
>   src/kdewebkit.widgets 9f07307a12b7e88f3a0ca9f5be9ad67f5640db3a 
> 
> Diff: https://git.reviewboard.kde.org/r/114705/diff/
> 
> 
> Testing
> -------
> 
> Still builds fine
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131229/90aef625/attachment.html>