<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114705/">https://git.reviewboard.kde.org/r/114705/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hehe, this is from 2001, back when designer was generating the whole dialog, not just its child widgets.
Commit log:
- You can now implement preview classes that cannot be directly added to
designer (in classpreviews.*), e.g. call reparent() for dialogs or insert
example values.
=> You can now create a KDialog
-> Doesn't apply at all anymore.</pre>
<br />
<p>- David Faure</p>
<br />
<p>On December 28th, 2013, 3:07 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 3:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesignerplugin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove classpreviews.{cpp,h}
It only contains a single class - KDialogPreview - which is unused
anywhere.
NB: this doesn't need to go into TP1, but if I don't post these patches, I'll forget I have them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(3e51888614358e71756774f6bbfd5d3c14921947)</span></li>
<li>src/classpreviews.h <span style="color: grey">(ec5545be046022917e9c6a6df6610f32965cccf9)</span></li>
<li>src/classpreviews.cpp <span style="color: grey">(1ae771162a844dd8efae3a110a1e056513ea01fe)</span></li>
<li>src/kde.widgets <span style="color: grey">(65f38391fe0cbffd1e8e000d1ce29dd483bc72fc)</span></li>
<li>src/kdewebkit.widgets <span style="color: grey">(9f07307a12b7e88f3a0ca9f5be9ad67f5640db3a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114705/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>