Review Request 114700: Add -DKCOREADDONS_LIB to the exported defines for KF5::CoreAddons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114700/#review46271
-----------------------------------------------------------


OK for this particular case, but in general I don't like Qt's -DQT_CORE_LIB very much because it is buildsystem dependent (i.e. it makes it more complicated to use a different buildsystem for the application than the one used by the library - qmake in Qt's case, cmake in our case).

- David Faure


On Dec. 28, 2013, 1:03 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114700/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 1:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Add -DKCOREADDONS_LIB to the exported defines for KF5::CoreAddons
> 
> This allows code (specifically, kimagecache.h in kguiaddons) to check
> whether KF5::CoreAddons has been linked against.
> 
> 
> In theory, we could apply this across the frameworks, in much the same way that Qt appears to do (it adds -DQT_CORE_LIB, -DQT_GUI_LIB etc etc).
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt 0e18f42b37055e7aa5b686ec72b1906a16512b80 
> 
> Diff: https://git.reviewboard.kde.org/r/114700/diff/
> 
> 
> Testing
> -------
> 
> KCoreAddons and things that depend on it still build.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131228/a80d1ac3/attachment.html>