Review Request 114700: Add -DKCOREADDONS_LIB to the exported defines for KF5::CoreAddons
Alex Merry
kde at randomguy3.me.uk
Sat Dec 28 13:03:03 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114700/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
-------
Add -DKCOREADDONS_LIB to the exported defines for KF5::CoreAddons
This allows code (specifically, kimagecache.h in kguiaddons) to check
whether KF5::CoreAddons has been linked against.
In theory, we could apply this across the frameworks, in much the same way that Qt appears to do (it adds -DQT_CORE_LIB, -DQT_GUI_LIB etc etc).
Diffs
-----
src/lib/CMakeLists.txt 0e18f42b37055e7aa5b686ec72b1906a16512b80
Diff: https://git.reviewboard.kde.org/r/114700/diff/
Testing
-------
KCoreAddons and things that depend on it still build.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131228/dae31da2/attachment.html>
More information about the Kde-frameworks-devel
mailing list