Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

[Aurélien Gâteau]

> On Dec. 16, 2013, 11:05 p.m., Nicolás Alvarez wrote:
> > This gets rid of the annoying "ignoring unknown option '-fexceptions'" I kept getting when compiling threadweaver with MSVC.

That's a bit surprising: flags should be the same. I suspect you have not applied the matching ECM patch from https://git.reviewboard.kde.org/r/114501/ :)


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114502/#review45830
-----------------------------------------------------------


On Dec. 16, 2013, 6:10 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114502/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 6:10 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Use the new KDE_ENABLE_EXCEPTIONS flag, define KDE4_ENABLE_EXCEPTIONS in KDE4Support. Needs https://git.reviewboard.kde.org/r/114501/
> 
> 
> Diffs
> -----
> 
>   tier4/khtml/src/CMakeLists.txt a8eb322 
>   tier4/kde4support/cmake/modules/FindKDE4Internal.cmake e3f8c63 
>   tier1/threadweaver/src/Weaver/CMakeLists.txt 8e18b46 
>   tier3/kio/src/kpac/CMakeLists.txt 57d5694 
>   tier1/kimageformats/src/imageformats/CMakeLists.txt 614bba0 
> 
> Diff: http://git.reviewboard.kde.org/r/114502/diff/
> 
> 
> Testing
> -------
> 
> kdelibs builds, even after removing the KDE4_ENABLE_EXCEPTIONS definition from ECM (see ECM review).
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131217/de2377cb/attachment.html>