<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114502/">http://git.reviewboard.kde.org/r/114502/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2013, 11:05 p.m. CET, <b>Nicolás Alvarez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This gets rid of the annoying "ignoring unknown option '-fexceptions'" I kept getting when compiling threadweaver with MSVC.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's a bit surprising: flags should be the same. I suspect you have not applied the matching ECM patch from https://git.reviewboard.kde.org/r/114501/ :)</pre>
<br />
<p>- Aurélien</p>
<br />
<p>On December 16th, 2013, 6:10 p.m. CET, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System and KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2013, 6:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use the new KDE_ENABLE_EXCEPTIONS flag, define KDE4_ENABLE_EXCEPTIONS in KDE4Support. Needs https://git.reviewboard.kde.org/r/114501/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdelibs builds, even after removing the KDE4_ENABLE_EXCEPTIONS definition from ECM (see ECM review).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier4/khtml/src/CMakeLists.txt <span style="color: grey">(a8eb322)</span></li>
<li>tier4/kde4support/cmake/modules/FindKDE4Internal.cmake <span style="color: grey">(e3f8c63)</span></li>
<li>tier1/threadweaver/src/Weaver/CMakeLists.txt <span style="color: grey">(8e18b46)</span></li>
<li>tier3/kio/src/kpac/CMakeLists.txt <span style="color: grey">(57d5694)</span></li>
<li>tier1/kimageformats/src/imageformats/CMakeLists.txt <span style="color: grey">(614bba0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114502/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>