KPageDialog - What happened to source compatibility?

[Kevin Ottens]

On Saturday 14 December 2013 16:30:04 Martin Graesslin wrote:
> On Saturday 14 December 2013 16:18:44 Albert Astals Cid wrote:
> > I think to remember one of the goals was that the KF5 would be as source
> > compatible as possible.
> > 
> > Now i see that KPageDialog is not a KDialog anymore and thus setButtons,
> > setDefaultButton, setButtonGuiItem, etc are not available in it anymore.
> > 
> > Now, i *do* understand that for the tierization some rework was needed,
> > otherwise you would not be able to get KPageDialog to be of tier1, but I
> > 
> > think that either of this should have happened:
> >  a) K4PageDialog exists in kde4support for all of us that are happy not
> > 
> > being strict about library dependenices
> > 
> >  b) KDE5PORTING.html has notes on how to port "KDE4 KPageDialog" to "KF5
> > 
> > KPageDialog" if it is really trivial.
> 
> +1 to improve the situation. I also run into this issue during porting
> $stuff. Shame on me for not raising the issue like Albert did.
> 
> There is an option
> c) add everything from kdialog marked as deprecated for source
> compatibility.

Makes sense to me, if possible put them purely in the header file.

> KPageDialog is not the only affected class. In fact everything which used to
> derive from KDialog is affected.

Yep, exactly. The KDialog -> QDialog transition is unfortunately the one which 
introduced the most SC breakage I think.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131214/85888796/attachment.sig>