KPageDialog - What happened to source compatibility?

[Martin Graesslin]

On Saturday 14 December 2013 16:40:23 Albert Astals Cid wrote:
> El Dissabte, 14 de desembre de 2013, a les 16:30:04, Martin Graesslin va
> 
> escriure:
> > On Saturday 14 December 2013 16:18:44 Albert Astals Cid wrote:
> > > I think to remember one of the goals was that the KF5 would be as source
> > > compatible as possible.
> > > 
> > > Now i see that KPageDialog is not a KDialog anymore and thus setButtons,
> > > setDefaultButton, setButtonGuiItem, etc are not available in it anymore.
> > > 
> > > Now, i *do* understand that for the tierization some rework was needed,
> > > otherwise you would not be able to get KPageDialog to be of tier1, but I
> > > 
> > > think that either of this should have happened:
> > >  a) K4PageDialog exists in kde4support for all of us that are happy not
> > > 
> > > being strict about library dependenices
> > > 
> > >  b) KDE5PORTING.html has notes on how to port "KDE4 KPageDialog" to "KF5
> > > 
> > > KPageDialog" if it is really trivial.
> > 
> > +1 to improve the situation. I also run into this issue during porting
> > $stuff.
> 
> Well, that means you have some experience then :)
> 
> Do you think b) is achievable? I.e. how hard is to document the KDialog to
> QDialog uses cases in KDE5PORTING.html ?
It's difficult, there are for example miss-matching signals. E.g. KDialog emits 
finished(), but QDialog emits finished(int). As one doesn't get a compile error 
for incorrect connects, this can be really annoying and I'm not sure 
documenting that really helps. See for example [1] for such an issue. 
Especially if it's somewhere underneath and one doesn't hit a compile error, 
it's easy to miss those connect problems.

Cheers
Martin

[1] b7a67bab6269f8cbd61c0fa293baa659b98184f7 kdelibs
> 
> Cheers,
>   Albert
> 
> > Shame on me for not raising the issue like Albert did.
> > 
> > There is an option
> > c) add everything from kdialog marked as deprecated for source
> > compatibility.
> > 
> > KPageDialog is not the only affected class. In fact everything which used
> > to derive from KDialog is affected.
> > 
> > Cheers
> > Martin
> 
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131214/4728c2db/attachment.sig>