Forcing Q_SLOTS on non frameworks code

[Albert Astals Cid]

El Dissabte, 14 de desembre de 2013, a les 14:30:14, Kevin Ottens va escriure:
> On Saturday 14 December 2013 13:55:50 Albert Astals Cid wrote:
> > Hi there, so here I am at the KF5 porting sprint at Barcelona trying to
> > port libkdegames and I am realizing that I can not use code like
> > 
> >   private slots:
> > anymore.
> > 
> > I understand that for frameworks libraries it is interesting to have
> > -DQT_NO_SIGNALS_SLOTS_KEYWORDS defined so we end up with code that is as
> > widely includable from anywhere, but forcing that to the rest of the world
> > is a bit too much if you ask me.
> 
> I don't think that was intended.
> 
> > Can we somehow make it so that people using frameworks are not forced to
> > add a remove_definitions so they get their code compiling?
> 
> Definitely need to be fixed... we need to find what ends up activating it
> for everyone. I would guess you get the same thing for the implicit ascii
> casts? That would not be intended either.

Yep, it's the same, I'll have a look to see where they come from.

Cheers,
  Albert

> 
> Regards.