Suggestion: create an own framework for KGlobalAccel

[Martin Graesslin]

On Sunday 08 December 2013 18:04:45 Albert Astals Cid wrote:
> El Diumenge, 8 de desembre de 2013, a les 10:16:36, Martin Graesslin va
> 
> escriure:
> > Hi,
> > 
> > at the moment KGlobalAccel is part of XmlGui which I consider semantically
> > wrong. Global shortcuts have nothing to do with XmlGui and there are quite
> > some examples for applications which need global shortcuts but do not use
> > xml gui (e.g. everything in the desktop shell).
> > 
> > My suggestion is to move the following source files into an own framework:
> > * kglobalaccel.cpp
> > * kglobalaccel.h
> > * kglobalaccel_p.h
> > * kglobalshortcutinfo.cpp
> > * kglobalshortcutinfo.h
> > * kglobalshortcutinfo_dbus.cpp
> > * kglobalshortcutinfo_p.h
> > * org.kde.kglobalaccel.Component.xml
> > * org.kde.KGlobalAccel.xml
> > 
> > From checking the source files this would become a tier1 framework as the
> > dependencies are:
> > * QtCore
> > * QtDBus
> > * QtWidgets
> > * QtX11Extras
> > 
> > Opinions?
> 
> Not an oposition but...
> 
> Is there no other tier1 framework where it would fit logically and
> dependency wise?
Probably Kevin or David can better comment on it. For me the only somewhat 
fitting framework would be KWidgetsAddons, but I don't know whether it would be 
OK to have more dependencies in that framework. WidgetsAddons only depends on 
Widgets, but GlobalAccel also needs DBus and X11Extras.

With my KWin hat on I wouldn't like putting it there, because it would mean 
that I get rid of XmlGui, but on the other hand introduce again a dependency 
on stuff we do not need.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131208/e36b5808/attachment-0001.sig>