Review Request 114336: Install all includes in a KF5 dir

Stephen Kelly steveire at gmail.com
Sat Dec 7 13:51:33 UTC 2013


Aurélien Gâteau wrote:

> 
> 
>> On Dec. 6, 2013, 5:15 p.m., Alexander Richardson wrote:
>> > Just wondering, should include/KF5 also be the include dir for
>> > applications that install headers e.g. for writing plugins? Since I
>> > guess they will also be using KDEInstallDirs.cmake
> 
> Good question. This was not discussed in the thread. I would say
> include/KF5 should only be used by frameworks, to be consistent with our
> library naming (using libKF5 as a prefix). This means the change should be
> done for each framework instead of in ecm. If everybody agrees, I can
> discard this RR and do the change in kdelibs only.

It might make sense for ECM to provide different settings for KF5-frameworks 
and for non-KF5-frameworks. Eg, instead of INSTALL_TARGETS_DEFAULT_ARGS, 
provide KF5_INSTALL_TARGETS_DEFAULT_ARGS.

Thanks,

Steve.





More information about the Kde-frameworks-devel mailing list