Review Request 114336: Install all includes in a KF5 dir

[Aurélien Gâteau]

> On Dec. 6, 2013, 5:15 p.m., Alexander Richardson wrote:
> > Just wondering, should include/KF5 also be the include dir for applications that install headers e.g. for writing plugins? Since I guess they will also be using KDEInstallDirs.cmake

Good question. This was not discussed in the thread. I would say include/KF5 should only be used by frameworks, to be consistent with our library naming (using libKF5 as a prefix). This means the change should be done for each framework instead of in ecm. If everybody agrees, I can discard this RR and do the change in kdelibs only.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114336/#review45278
-----------------------------------------------------------


On Dec. 6, 2013, 5 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114336/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 5 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Install all includes in a KF5 dir. This is the first step to implement the header policy discussed on kde-frameworks-devel.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake d94adcf 
> 
> Diff: http://git.reviewboard.kde.org/r/114336/diff/
> 
> 
> Testing
> -------
> 
> Removed install dir, then rebuilt kdelibs, kactivities, kde-runtime, plasma-framework, kde-workspace, libnm-qt and plasma-nm
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131206/d2125ac9/attachment.html>