Review Request 114184: Remove everything in kstyle that is not about KDE integration

[Hugo Pereira Da Costa]

Hi all,

KStyle::customStyleElement:

- was a nice (though somewhat hacky) technology to let a style or a 
widget define custom style hints that would then be accessible to the 
external world.
- is now gone (well: move to K4Style)
- was unfortunatly used between oxygen style and oxygen decorations, so 
that oxygen style could tell the decoration that it supports ARGB drag 
and drop icons (which Qt does not by default), and the decoration, in 
turns would add shadows to the drag icon generated for tabbed widgets ...

As a consequence: kde-workspace currently does not compile.
We can:
1/ re-add the functionality inside kstyle (its a couple of static 
functions basically)
2/ use K4Style but that would make oxygen-decoration depend on KDE4Support
3/ drop the functionality: but then: no shadows around drag and drop 
icon for tabbed windows, because it looks ugly for styles that do not 
support ARGB drag and drop icon
4/ Anything else ? (suggestions welcome)

I'd vote for 1/ and volunteer to make the change if agreed.

Comments ?

Hugo

> This is an automatically generated e-mail. To reply, visit: 
> http://git.reviewboard.kde.org/r/114184/
>
>
>   This change has been marked as submitted.
>
>
> Review request for KDE Frameworks.
> By Àlex Fiestas.
>
> /Updated Dec. 5, 2013, 2:22 p.m./
>
> *Repository: * kdelibs
>
>
>   Description
>
> Removed everything from KStyle that is NOT about integrating with KDE.
>
>
>   Diffs
>
>   * tier4/frameworkintegration/src/kstyle/kstyle.h (4c83509)
>   * tier4/frameworkintegration/src/kstyle/kstyle.cpp (626d2a9)
>
> View Diff <http://git.reviewboard.kde.org/r/114184/diff/>
>
>
>
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131205/f3c7a9db/attachment-0001.html>