<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi all,<br>
<br>
KStyle::customStyleElement:<br>
<br>
- was a nice (though somewhat hacky) technology to let a style or a
widget define custom style hints that would then be accessible to
the external world.<br>
- is now gone (well: move to K4Style)<br>
- was unfortunatly used between oxygen style and oxygen decorations,
so that oxygen style could tell the decoration that it supports ARGB
drag and drop icons (which Qt does not by default), and the
decoration, in turns would add shadows to the drag icon generated
for tabbed widgets ...<br>
<br>
As a consequence: kde-workspace currently does not compile. <br>
We can:<br>
1/ re-add the functionality inside kstyle (its a couple of static
functions basically)<br>
2/ use K4Style but that would make oxygen-decoration depend on
KDE4Support<br>
3/ drop the functionality: but then: no shadows around drag and drop
icon for tabbed windows, because it looks ugly for styles that do
not support ARGB drag and drop icon<br>
4/ Anything else ? (suggestions welcome)<br>
<br>
I'd vote for 1/ and volunteer to make the change if agreed.<br>
<br>
Comments ? <br>
<br>
Hugo<br>
<br>
<blockquote cite="mid:20131205142217.14488.11767@vidsolbach.de"
type="cite">
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table style="border: 1px #c9c399 solid;" bgcolor="#f9f3c9"
cellpadding="8" width="100%">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To reply,
visit: <a moz-do-not-send="true"
href="http://git.reviewboard.kde.org/r/114184/">http://git.reviewboard.kde.org/r/114184/</a>
</td>
</tr>
</tbody>
</table>
<br>
<table style="border: 1px gray solid;" bgcolor="#e0e0e0"
cellpadding="8" width="100%">
<tbody>
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size:
10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</tbody>
</table>
<br>
<table style="background-image:
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');
background-position: left top; background-repeat: repeat-x;
border: 1px black solid;" bgcolor="#fefadf" cellpadding="8"
cellspacing="0" width="100%">
<tbody>
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Dec. 5, 2013, 2:22
p.m.</i></p>
<div style="margin-top: 1.5em;"> <b style="color:
#575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Description </h1>
<table style="border: 1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed everything from KStyle that is NOT about integrating with KDE.</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier4/frameworkintegration/src/kstyle/kstyle.h <span
style="color: grey">(4c83509)</span></li>
<li>tier4/frameworkintegration/src/kstyle/kstyle.cpp <span
style="color: grey">(626d2a9)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="http://git.reviewboard.kde.org/r/114184/diff/"
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kde-frameworks-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kde-frameworks-devel@kde.org">Kde-frameworks-devel@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>