Review Request 112363: Make it possible for QToolBar to use "Other toolbar" settings

Commit Hook null at kde.org
Sat Aug 31 14:41:02 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112363/#review39022
-----------------------------------------------------------


This review has been submitted with commit 33dc6599948e6a69a97d99929f418939d56268f3 by Àlex Fiestas to branch frameworks.

- Commit Hook


On Aug. 29, 2013, 4:13 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112363/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 4:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Qt only knows about one kind of Toolbar while in KDE we know about
> two, one we call "Main Toolbar" and another one called "Other Toolbars".
>     
> This commit adds a small hack that makes it possible for an application
> not using KToolbar (for example beacuse it can't depend on XMLGui) use
> "Other Toolbar" by setting the dynamic property "otherToolbar" to any
> value, for example true.
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html dcffa27 
>   staging/frameworkintegration/autotests/CMakeLists.txt d91eb7a 
>   staging/frameworkintegration/autotests/kdeplatformtheme_kdeglobals 351074b 
>   staging/frameworkintegration/autotests/kstyle_unittest.cpp PRE-CREATION 
>   staging/frameworkintegration/src/kstyle/kstyle.cpp 7257b9d 
>   staging/xmlgui/src/ktoolbar.h d786a17 
> 
> Diff: http://git.reviewboard.kde.org/r/112363/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130831/50a5efa7/attachment.html>


More information about the Kde-frameworks-devel mailing list