<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112363/">http://git.reviewboard.kde.org/r/112363/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 33dc6599948e6a69a97d99929f418939d56268f3 by Àlex Fiestas to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 29th, 2013, 4:13 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2013, 4:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Qt only knows about one kind of Toolbar while in KDE we know about
two, one we call "Main Toolbar" and another one called "Other Toolbars".
This commit adds a small hack that makes it possible for an application
not using KToolbar (for example beacuse it can't depend on XMLGui) use
"Other Toolbar" by setting the dynamic property "otherToolbar" to any
value, for example true.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(dcffa27)</span></li>
<li>staging/frameworkintegration/autotests/CMakeLists.txt <span style="color: grey">(d91eb7a)</span></li>
<li>staging/frameworkintegration/autotests/kdeplatformtheme_kdeglobals <span style="color: grey">(351074b)</span></li>
<li>staging/frameworkintegration/autotests/kstyle_unittest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/frameworkintegration/src/kstyle/kstyle.cpp <span style="color: grey">(7257b9d)</span></li>
<li>staging/xmlgui/src/ktoolbar.h <span style="color: grey">(d786a17)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112363/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>