Review Request 112177: Split URL drop functionality from KLineEdit

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112177/#review38969
-----------------------------------------------------------

Ship it!


Just a minor docu improvement, then you can push this. Thanks!


staging/kcompletion/src/kcombobox.h
<http://git.reviewboard.kde.org/r/112177/#comment28739>

    @deprecated since 5.0. Use ...



staging/kcompletion/src/klineedit.h
<http://git.reviewboard.kde.org/r/112177/#comment28740>

    same here


- David Faure


On Aug. 27, 2013, 9:49 a.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112177/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 9:49 a.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Description
> -------
> 
> The replace content on URL drop functionality that was present in KLineEdit has been moved to a separate class, that can be installed as an event filter in any QLineEdit (KLineEdit, QComboBox, KUrlRequester...). 
> 
> KLineEdit now uses this new class when the property "urlDropsEnabled" is enabled, but this property has been marked as deprecated in favour of the new alternative.
> 
> 
> Diffs
> -----
> 
>   tier1/kwidgetsaddons/src/lineediturldropeventfilter.cpp PRE-CREATION 
>   tier1/kwidgetsaddons/src/lineediturldropeventfilter.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/CMakeLists.txt c17c648 
>   staging/kcompletion/src/klineedit.cpp 213b196 
>   staging/kcompletion/src/klineedit.h e9f3332 
>   staging/kcompletion/src/kcombobox.h 0d4e912 
> 
> Diff: http://git.reviewboard.kde.org/r/112177/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + tests passed
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130830/e47dcd44/attachment.html>