Review Request 112177: Split URL drop functionality from KLineEdit

Albert Vaca Cintora albertvaka at gmail.com
Tue Aug 27 09:49:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112177/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 11:49 a.m.)


Review request for KDE Frameworks and Kevin Ottens.


Description
-------

The replace content on URL drop functionality that was present in KLineEdit has been moved to a separate class, that can be installed as an event filter in any QLineEdit (KLineEdit, QComboBox, KUrlRequester...). 

KLineEdit now uses this new class when the property "urlDropsEnabled" is enabled, but this property has been marked as deprecated in favour of the new alternative.


Diffs
-----

  tier1/kwidgetsaddons/src/lineediturldropeventfilter.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/lineediturldropeventfilter.h PRE-CREATION 
  tier1/kwidgetsaddons/src/CMakeLists.txt c17c648 
  staging/kcompletion/src/klineedit.cpp 213b196 
  staging/kcompletion/src/klineedit.h e9f3332 
  staging/kcompletion/src/kcombobox.h 0d4e912 

Diff: http://git.reviewboard.kde.org/r/112177/diff/


Testing
-------

Manual testing + tests passed


Thanks,

Albert Vaca Cintora

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130827/d4dca8e7/attachment.html>


More information about the Kde-frameworks-devel mailing list