Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

[Kevin Ottens]

> On Aug. 26, 2013, 6:47 a.m., Kevin Ottens wrote:
> > Looks OK. Assuming you ran the whole kdelibs test suite and it all passed.
> 
> Martin Klapetek wrote:
>     Actually running the whole suite I have 6 tests failing with no patches and a clean build (running the tests as described in the wiki), some of them even segfaulting. But with this patch applied, only the same tests fail. 
>     
>     Can someone with local 100% successful tests please apply this and see if this breaks something? Thanks.

Well, it'd be nice if you could investigate why you got failing tests. You can't really do a proper work in the long term without a clean baseline on KF5.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112229/#review38574
-----------------------------------------------------------


On Aug. 23, 2013, 8:02 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112229/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 8:02 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Removes more of direct POSIX calls and replaces them with QT_STUFF.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/src/core/kconfigini.cpp c484ecb 
>   kioslave/ftp/ftp.cpp 1060959 
>   staging/kio/src/widgets/kdirmodel.cpp 77b978a 
>   kioslave/file/file_unix.cpp f4bc812 
>   kdesu/su.cpp f0b1a35 
>   kded/kbuildsycoca.cpp b376a3c 
>   kdesu/client.cpp 5e11f96 
>   tier1/kcoreaddons/src/lib/io/kdirwatch.cpp 903883e 
>   tier1/kcoreaddons/src/lib/io/kprocess.cpp 8f9c1af 
> 
> Diff: http://git.reviewboard.kde.org/r/112229/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130827/3bc950bf/attachment-0001.html>