<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112229/">http://git.reviewboard.kde.org/r/112229/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2013, 6:47 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks OK. Assuming you ran the whole kdelibs test suite and it all passed.</pre>
</blockquote>
<p>On August 26th, 2013, 4:01 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually running the whole suite I have 6 tests failing with no patches and a clean build (running the tests as described in the wiki), some of them even segfaulting. But with this patch applied, only the same tests fail.
Can someone with local 100% successful tests please apply this and see if this breaks something? Thanks.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, it'd be nice if you could investigate why you got failing tests. You can't really do a proper work in the long term without a clean baseline on KF5.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On August 23rd, 2013, 8:02 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2013, 8:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removes more of direct POSIX calls and replaces them with QT_STUFF.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kconfig/src/core/kconfigini.cpp <span style="color: grey">(c484ecb)</span></li>
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(1060959)</span></li>
<li>staging/kio/src/widgets/kdirmodel.cpp <span style="color: grey">(77b978a)</span></li>
<li>kioslave/file/file_unix.cpp <span style="color: grey">(f4bc812)</span></li>
<li>kdesu/su.cpp <span style="color: grey">(f0b1a35)</span></li>
<li>kded/kbuildsycoca.cpp <span style="color: grey">(b376a3c)</span></li>
<li>kdesu/client.cpp <span style="color: grey">(5e11f96)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kdirwatch.cpp <span style="color: grey">(903883e)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kprocess.cpp <span style="color: grey">(8f9c1af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112229/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>