oxygen vs kstyle

[Kevin Ottens]

Hello,

On Tuesday 20 August 2013 21:27:52 Hugo Pereira Da Costa wrote:
> There is some traffic on the frameworks list concerning implementing new
> features in kstyle.
> It might be useful to mention that the current oxygen code (KDE's
> default widget style) derives from QCommonStyle and not kstyle, so that
> none of the modifications to KStyle will be available to oxygen, as it
> is now.

Yep, heard about that.
 
> The switch from KStyle to QCommonStyle happened a couple of years ago
> and was motivated by the fact that the extra complexity added by
> deriving from kstyle was higher than the benefit oxygen would get out of
> it (complexity being: a lot of method re-implemented, as well as a lot
> of enumerations, some workaround in kstyle that where obsolete and
> unmaintained, and quite some code duplication). This switch resulted in
> about 30% less code with no loss of functionality, and an easier code to
> read and debug (if only by having one less class to track in the
> dependency tree).
> 
> Suggestions about where to go from this situation are welcome.

My understanding of the current situation is that:
 a) the current KStyle is overengineered and does way too much;
 b) we need a KStyle to enforce some of the user settings consistently across 
the styles we produce (it's actually more important than before as some of the 
stuff we controlled on the widget side will be controlled on the style side 
now).

So I think the best thing to do there is to severely trim down KStyle. I'd 
propose we copy KStyle as it is now into KDE4Support under the name K4Style. 
And then we empty KStyle as much as possible I really see the need for it to 
only have reimplemented: polish/unpolish, styleHint, eventFilter (likely 
different code than the current one though) and *maybe* a few pixelMetrics and 
standardIcons. All the rest looks to me as overkill which makes style 
developers life miserable anyway.

Does it sound acceptable to you? If yes we can start on our side, and once 
trimmed down I'd like a review from you to see if anything still makes your 
life more complicated than necessary as a style developer.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by BlueSystems and KDAB to work on KDE Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130820/6b5a0488/attachment.sig>