oxygen vs kstyle

[Hugo Pereira Da Costa]

On 08/20/2013 09:45 PM, Christoph Feck wrote:
> On Tuesday 20 August 2013 21:27:52 Hugo Pereira Da Costa wrote:
>> Hi All,
>>
>> There is some traffic on the frameworks list concerning
>> implementing new features in kstyle.
>> It might be useful to mention that the current oxygen code (KDE's
>> default widget style) derives from QCommonStyle and not kstyle, so
>> that none of the modifications to KStyle will be available to
>> oxygen, as it is now.
>>
>> The switch from KStyle to QCommonStyle happened a couple of years
>> ago and was motivated by the fact that the extra complexity added
>> by deriving from kstyle was higher than the benefit oxygen would
>> get out of it (complexity being: a lot of method re-implemented,
>> as well as a lot of enumerations, some workaround in kstyle that
>> where obsolete and unmaintained, and quite some code duplication).
>> This switch resulted in about 30% less code with no loss of
>> functionality, and an easier code to read and debug (if only by
>> having one less class to track in the dependency tree).
>>
>> Suggestions about where to go from this situation are welcome.
> My suggestion is to simply kill KStyle. Rename it to K4Style. No style
> ever used it. Its static methods to handle style additions can be
> moved to a new namespace KStyle to minimize SIC.
>
> (killing == moving it to wherever other now unmaintained stuff is
> moved to).
+1 on my side.