Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Aug 20 17:27:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112175/
-----------------------------------------------------------
(Updated Aug. 20, 2013, 5:27 p.m.)
Review request for KDE Frameworks.
Changes
-------
solved the issues David suggested:
- missing file
- made porting message more verbose
Description
-------
Make it possible to make sure that we keep reacting properly to ctrl+enter after switching from QDialog to KDialog by intercepting QDialogButtonBox creation and injecting the desired shortcut to it.
Diffs (updated)
-----
staging/frameworkintegration/src/kstyle/tests/kstyletest.cpp PRE-CREATION
staging/frameworkintegration/src/kstyle/tests/CMakeLists.txt PRE-CREATION
staging/frameworkintegration/src/kstyle/kstyle.cpp 63506476
KDE5PORTING.html f820ca1
staging/frameworkintegration/src/kstyle/CMakeLists.txt 265eff4
Diff: http://git.reviewboard.kde.org/r/112175/diff/
Testing
-------
Created a "kstyletest" that shows a dialog with a text edit and makes sure that this works.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130820/87dc9334/attachment.html>
More information about the Kde-frameworks-devel
mailing list