Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112175/#review38221
-----------------------------------------------------------



KDE5PORTING.html
<http://git.reviewboard.kde.org/r/112175/#comment28245>

    People will wonder why they have to do this in every single dialog. Maybe complete the sentence with "if the dialog uses a QTextEdit", or if you feel that the user uses the dialog very often and should be able to close it quickly with a shortcut that works everywhere in the dialog.
    
    And mention that KStyle takes care of it, for KDE-based widget styles. Otherwise KDE developers will wonder why it works without them adding it :-)



staging/frameworkintegration/src/kstyle/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112175/#comment28246>

    missing


- David Faure


On Aug. 20, 2013, 5:06 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112175/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 5:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Make it possible to make sure that we keep reacting properly to ctrl+enter after switching from QDialog to KDialog by intercepting QDialogButtonBox creation and injecting the desired shortcut to it.
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html f820ca1 
>   staging/frameworkintegration/src/kstyle/CMakeLists.txt 265eff4 
>   staging/frameworkintegration/src/kstyle/kstyle.cpp 63506476 
> 
> Diff: http://git.reviewboard.kde.org/r/112175/diff/
> 
> 
> Testing
> -------
> 
> Created a "kstyletest" that shows a dialog with a text edit and makes sure that this works.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130820/af6d708d/attachment.html>